fix(patterns): find all patterns inlcuding pseudo patterns#978
Conversation
find all patterns including pseudo patterns and sort them after retrieving all patterns instead of inject them in the array working on fixes issue pattern-lab#975
|
Sweet, thanks @dersiedler1! AChecking this out later today or early tomorrow (unless @bmuenzenmeyer beats me to it) - hang tight! |
There was a problem hiding this comment.
I can confirm that this seems to fix this buggy psuedo-pattern behavior after replicating the problem mentioned in #975 (comment) -- this update does indeed fix #975!
Side note: While doing some local testing, I did notice that this quirky behavior seemed to (mostly?) happen when things weren't nested in a separate folder (ie organizing patterns like atoms/button.hbs and atoms/button~primary.json but not atoms/buttons/button.hbs and atoms/buttons/button~primary.json) however I think that'll require some more digging around -- separate chunk of work that shouldn't block this one from getting in.
Thanks guys!
Great thanks @sghoweri. Any ideas when a new beta version might be pushed for |
3 participants
Closes #975
Summary of changes:
find all patterns including pseudo patterns and sort them after
retrieving all patterns instead of inject them in the array working on